Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code health] Replace mock with actual implementation in DataCollectionFragmentTest #2886

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[Code health] Replace mock with actual implementation in DataCollectionFragmentTest #2886

wants to merge 8 commits into from
+100 −86

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Dec 1, 2024 •
edited
Loading

Towards #2134
Towards #2840

Replaces mock implementation of SubmissionRepository with actual implementation in DataCollectionFragmentTest.

This improves the test coverage for SubmissionRepository by 60% and overall coverage by 1%.

Since this is a test-only change, so end-user behavior remains no-op.

@gino-m @anandwana001 PTAL?

@shobhitagarwal1612 shobhitagarwal1612 requested review from gino-m and removed request for scolsen December 1, 2024 10:13
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.73%. Comparing base (9ab91bc) to head (2c52a5a).

Files with missing lines Patch % Lines
...rsistence/local/room/stores/RoomSubmissionStore.kt 25.00% 3 Missing ⚠️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2886      +/-   ##
============================================
+ Coverage     61.68%   62.73%   +1.05%     
- Complexity     1173     1203      +30     
============================================
  Files           268      268              
  Lines          6344     6346       +2     
  Branches        876      876              
============================================
+ Hits           3913     3981      +68     
+ Misses         1890     1820      -70     
- Partials        541      545       +4
Files with missing lines Coverage Δ
.../android/ground/repository/SubmissionRepository.kt 80.00% <100.00%> (+61.39%) ⬆️
...ogle/android/ground/ui/home/HomeScreenViewModel.kt 78.84% <50.00%> (-0.40%) ⬇️
...rsistence/local/room/stores/RoomSubmissionStore.kt 69.30% <25.00%> (+9.30%) ⬆️

... and 7 files with indirect coverage changes

@shobhitagarwal1612 shobhitagarwal1612 changed the title [Test Coverage] Replace mock with actual implementation in DataCollectionFragmentTest [Code health] Replace mock with actual implementation in DataCollectionFragmentTest Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@gino-m gino-m Awaiting requested review from gino-m

Assignees

@gino-m gino-m

@anandwana001 anandwana001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobhitagarwal1612 @anandwana001 @gino-m